Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dev-v2.8] Bump rancher-monitoring/rancher-monitoring to use new rancher/shell #3656

Merged
merged 2 commits into from
Apr 5, 2024
Merged

[dev-v2.8] Bump rancher-monitoring/rancher-monitoring to use new rancher/shell #3656

merged 2 commits into from
Apr 5, 2024

Conversation

mallardduck
Copy link
Member

@mallardduck mallardduck commented Mar 18, 2024 •
edited
Loading

Issue:

SURE-7080

Problem

See original issue

Solution

See original issue

Testing

Engineering Testing

Manual Testing

Installed 103.0.3+up45.31.1 via Apps, upgraded to 103.0.4+up45.31.1, then subsequently to 103.0.5-rc1+up45.31.1.
Upon upgrade to 103.0.5-rc1+up45.31.1 I can observe shell v0.1.23 in use as expected.

Automated Testing

QA Testing Considerations

Regressions Considerations

Backporting considerations

@mallardduck mallardduck requested review from a team as code owners March 18, 2024 17:16
@github-actions GitHub Actions
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

alexandreLamarre
alexandreLamarre requested changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@alexandreLamarre alexandreLamarre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some chart validation errors as well. Run make validate and make-check-release-yaml locally, these will help

packages/rancher-monitoring/rancher-monitoring/package.yaml Outdated Show resolved Hide resolved
packages/rancher-monitoring/rancher-monitoring/templates/crd-template/values.yaml Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@mallardduck mallardduck changed the title WIP: Bump rancher-monitoring/rancher-monitoring to use new rancher/shell [dev-v2.8] Bump rancher-monitoring/rancher-monitoring to use new rancher/shell Mar 18, 2024
lucasmlp
lucasmlp requested changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@lucasmlp lucasmlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pointed out some changes to be made on release.yaml. Otherwise PR looks good to me.
One thing that I would also comment is: rancher-monitoring 103.0.3+up45.31.1 is released in Rancher v2.8. IMO there's no need to bump the chart beyond 103.0.4. You could follow this workflow after 103.0.3+up45.31.1 was released:

  • Bump the chart to 103.0.4+up45.31.1-RC1
  • Make your changes in packages folder
  • commit
  • make charts
  • commit
  • Open and merge PR
    • If the result is not satisfactory, make another bump to RC2
    • Make your changes in packages folder
    • commit
    • make charts
    • commit
    • Open and merge PR
    • Repeat until the result is satisfactory
  • Open PR to un-RC the chart

Please tell me what you think about his workflow. I would like to know more about the feature chart owner team's needs to rework our developing documentation 🙂

release.yaml Outdated Show resolved Hide resolved
release.yaml Outdated Show resolved Hide resolved
@mallardduck mallardduck marked this pull request as draft March 19, 2024 17:21
@github-actions GitHub Actions
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@github-actions GitHub Actions
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@github-actions GitHub Actions
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@mallardduck mallardduck marked this pull request as ready for review March 29, 2024 21:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

alexandreLamarre
alexandreLamarre requested changes Apr 2, 2024
View reviewed changes
release.yaml Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@mallardduck mallardduck self-assigned this Apr 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

lucasmlp
lucasmlp approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@lucasmlp lucasmlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 5, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@mallardduck
Copy link
Member Author

Validation Template

What was fixed, or what change have occurred

The version of rancher/shell in use during upgrades of rancher-monitoring apps was bumped.

Areas or cases that should be tested

Upgrading from an older version of rancher-monitoring to this version.

  1. Install an older version of rancher-monitoring.
  2. Give app time to fully deploy and setup.
  3. Upgrade to this version of the chart and confirm upgrade completes properly.

What areas could experience regressions

The upgrade jobs that run for rancher-monitoring and rancher-monitoring-crd.

Are the repro steps accurate/minimal?

Yes.

@alexandreLamarre alexandreLamarre merged commit f74aefb into rancher:dev-v2.8 Apr 5, 2024
7 checks passed
@aruiz14 aruiz14 mentioned this pull request Apr 8, 2024
Merged
lucasmlp pushed a commit that referenced this pull request May 8, 2024
@mallardduck @lucasmlp
[dev-v2.8] Bump rancher-monitoring/rancher-monitoring to use new ranc…
84ed7a2 
…her/shell (#3656)
@lucasmlp lucasmlp mentioned this pull request May 8, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkpickering adamkpickering adamkpickering approved these changes

@lucasmlp lucasmlp lucasmlp approved these changes

@alexandreLamarre alexandreLamarre alexandreLamarre approved these changes

Assignees

@mallardduck mallardduck

Labels
team/observability&backup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mallardduck @adamkpickering @lucasmlp @alexandreLamarre